Call for review

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Call for review

jbonofre
Hi all,

I've started the Jetty 9.4.x upgrade in Pax Web 7.0.x.

I created the PR:

https://github.com/ops4j/org.ops4j.pax.web/pull/183

I've a couple of itests failure that I'm investigating.

Anyway, if some of you can take a look on the PR, it would be great !

I would like to merge this PR as soon as it's clean, in order for me to cut Pax
Web 7.0.0 and upgrade in Karaf for 4.2.0 release.

Thanks !

Regards
JB
--
Jean-Baptiste Onofré
[hidden email]
http://blog.nanthrax.net
Talend - http://www.talend.com
Reply | Threaded
Open this post in threaded view
|

Re: Call for review

jbonofre
FYI, I just fixed the itests failure (it was due to a method removed in Jetty
9.4 and define in the jetty.xml addBean).

I'm doing a new round and testing in Karaf locally.

Regards
JB

On 03/04/2018 06:16 AM, Jean-Baptiste Onofré wrote:

> Hi all,
>
> I've started the Jetty 9.4.x upgrade in Pax Web 7.0.x.
>
> I created the PR:
>
> https://github.com/ops4j/org.ops4j.pax.web/pull/183
>
> I've a couple of itests failure that I'm investigating.
>
> Anyway, if some of you can take a look on the PR, it would be great !
>
> I would like to merge this PR as soon as it's clean, in order for me to cut Pax
> Web 7.0.0 and upgrade in Karaf for 4.2.0 release.
>
> Thanks !
>
> Regards
> JB
>

--
Jean-Baptiste Onofré
[hidden email]
http://blog.nanthrax.net
Talend - http://www.talend.com
Reply | Threaded
Open this post in threaded view
|

Re: Call for review

Grzegorz Grzybek
Hello!

I already run all itests for pax-web 7.0.x before Jetty upgraade, so the
branch should be fine if you fixed Jetty upgrade issues.

best regards
Grzegorz Grzybek

2018-03-04 7:58 GMT+01:00 Jean-Baptiste Onofré <[hidden email]>:

> FYI, I just fixed the itests failure (it was due to a method removed in
> Jetty
> 9.4 and define in the jetty.xml addBean).
>
> I'm doing a new round and testing in Karaf locally.
>
> Regards
> JB
>
> On 03/04/2018 06:16 AM, Jean-Baptiste Onofré wrote:
> > Hi all,
> >
> > I've started the Jetty 9.4.x upgrade in Pax Web 7.0.x.
> >
> > I created the PR:
> >
> > https://github.com/ops4j/org.ops4j.pax.web/pull/183
> >
> > I've a couple of itests failure that I'm investigating.
> >
> > Anyway, if some of you can take a look on the PR, it would be great !
> >
> > I would like to merge this PR as soon as it's clean, in order for me to
> cut Pax
> > Web 7.0.0 and upgrade in Karaf for 4.2.0 release.
> >
> > Thanks !
> >
> > Regards
> > JB
> >
>
> --
> Jean-Baptiste Onofré
> [hidden email]
> http://blog.nanthrax.net
> Talend - http://www.talend.com
>