[GitHub] karaf pull request #282: Expose Dependency.hasVersion()

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] karaf pull request #282: Expose Dependency.hasVersion()

grgrzybek
GitHub user rovarga opened a pull request:

    https://github.com/apache/karaf/pull/282

    Expose Dependency.hasVersion()

    Since Dependency.getVersion() behaves the same as Feature.getVersion()
    by returning "0.0.0" when no version is set, users attempting to examine
    dependencies need to resort to touching the internal model to understand
    that the version is not actually set.
   
    Expose Dependency.hasVersion() to help potential users to understand
    that the version has not been set.
   
    Signed-off-by: Robert Varga <[hidden email]>

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/rovarga/karaf dependency-hasversion

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/karaf/pull/282.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #282
   
----
commit 400bcea403ad2e2409570421a9cf7f0a21e4bd02
Author: Robert Varga <[hidden email]>
Date:   2017-02-13T20:02:36Z

    Expose Dependency.hasVersion()
   
    Since Dependency.getVersion() behaves the same as Feature.getVersion()
    by returning "0.0.0" when no version is set, users attempting to examine
    dependencies need to resort to touching the internal model to understand
    that the version is not actually set.
   
    Expose Dependency.hasVersion() to help potential users to understand
    that the version has not been set.
   
    Signed-off-by: Robert Varga <[hidden email]>

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] karaf pull request #282: Expose Dependency.hasVersion()

grgrzybek
Github user asfgit closed the pull request at:

    https://github.com/apache/karaf/pull/282


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Loading...