Quantcast

[GitHub] karaf pull request #290: KARAF-5055: use karaf shutdown timeout when notifyi...

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] karaf pull request #290: KARAF-5055: use karaf shutdown timeout when notifyi...

earcam-2
GitHub user johnpoth opened a pull request:

    https://github.com/apache/karaf/pull/290

    KARAF-5055: use karaf shutdown timeout when notifying the service wra…

    …pper
   
    https://issues.apache.org/jira/browse/KARAF-5055
   
    Instead of notifying the service wrapper every 5 seconds that we are awaiting shutdown for 5*2 seconds or so, I propose to notify once the service wrapper that we are shutting down using the Karaf shutdown timeout.
   
    I've tested both when the timeout is reached(ungraceful shutdown) and when it's not (graceful shutdown). Both cases yield expected behavior.
   
    Thanks!

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/johnpoth/karaf KARAF-5055

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/karaf/pull/290.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #290
   
----
commit 79f78a8a3c6621f7e31aea8476a1b441404e4073
Author: jpoth <[hidden email]>
Date:   2017-03-22T12:43:08Z

    KARAF-5055: use karaf shutdown timeout when notifying the service wrapper

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[GitHub] karaf pull request #290: KARAF-5055: use karaf shutdown timeout when notifyi...

earcam-2
Github user asfgit closed the pull request at:

    https://github.com/apache/karaf/pull/290


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---
Loading...