Re: svn commit: r1039196 - /karaf/trunk/assembly/src/main
Locked
Re: svn commit: r1039196 - /karaf/trunk/assembly/src/main
 
|
On Thu, Nov 25, 2010 at 23:06, <[hidden email]> wrote:
> Author: anierbeck > Date: Thu Nov 25 22:06:39 2010 > New Revision: 1039196 > > URL: http://svn.apache.org/viewvc?rev=1039196&view=rev > Log: > [KARAF-290] Added additional dependency for EventAdminService > > Modified: > karaf/trunk/assembly/src/main/filtered-resources/features.xml > > Modified: karaf/trunk/assembly/src/main/filtered-resources/features.xml > URL: http://svn.apache.org/viewvc/karaf/trunk/assembly/src/main/filtered-resources/features.xml?rev=1039196&r1=1039195&r2=1039196&view=diff > ============================================================================== > --- karaf/trunk/assembly/src/main/filtered-resources/features.xml (original) > +++ karaf/trunk/assembly/src/main/filtered-resources/features.xml Thu Nov 25 22:06:39 2010 > @@ -125,6 +125,10 @@ > <bundle>mvn:org.apache.aries.jmx/org.apache.aries.jmx/${aries.jmx.version}</bundle> > <bundle>mvn:org.apache.aries.jmx/org.apache.aries.jmx.blueprint/${aries.jmx.version}</bundle> > </feature> > + <feature name="eventadmin" version="${project.version}" resolver="(obr)"> > + <bundle dependency="true">mvn:org.apache.felix/org.apache.felix.eventadmin/${felix.eventadmin.version}</bundle> I think the depedency attribute should be set to "false", else it won't be installed if you deploy the obr feature before that I think. > + <bundle dependency="true">mvn:org.apache.felix/org.apache.felix.webconsole.plugins.event/${felix.eventadmin-plugin.version}</bundle> Same here. However, won't that make the feature fail if the web console is not installed? > + </feature> > <feature name="jasypt-encryption" version="${project.version}" resolver="(obr)"> > <bundle dependency='true'>mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.commons-codec/${commons-codec.bundle.version}</bundle> > <bundle dependency='true'>mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.commons-lang/${commons-lang.bundle.version}</bundle> > > > -- Cheers, Guillaume Nodet ------------------------ Blog: http://gnodet.blogspot.com/ ------------------------ Open Source SOA http://fusesource.com |
Re: svn commit: r1039196 - /karaf/trunk/assembly/src/main
|
Thanks I will fix this, tonight.
2010/11/25 Guillaume Nodet <[hidden email]> > On Thu, Nov 25, 2010 at 23:06, <[hidden email]> wrote: > > Author: anierbeck > > Date: Thu Nov 25 22:06:39 2010 > > New Revision: 1039196 > > > > URL: http://svn.apache.org/viewvc?rev=1039196&view=rev > > Log: > > [KARAF-290] Added additional dependency for EventAdminService > > > > Modified: > > karaf/trunk/assembly/src/main/filtered-resources/features.xml > > > > Modified: karaf/trunk/assembly/src/main/filtered-resources/features.xml > > URL: > http://svn.apache.org/viewvc/karaf/trunk/assembly/src/main/filtered-resources/features.xml?rev=1039196&r1=1039195&r2=1039196&view=diff > > > ============================================================================== > > --- karaf/trunk/assembly/src/main/filtered-resources/features.xml > (original) > > +++ karaf/trunk/assembly/src/main/filtered-resources/features.xml Thu Nov > 25 22:06:39 2010 > > @@ -125,6 +125,10 @@ > > > <bundle>mvn:org.apache.aries.jmx/org.apache.aries.jmx/${aries.jmx.version}</bundle> > > > <bundle>mvn:org.apache.aries.jmx/org.apache.aries.jmx.blueprint/${aries.jmx.version}</bundle> > > </feature> > > + <feature name="eventadmin" version="${project.version}" > resolver="(obr)"> > > + <bundle > dependency="true">mvn:org.apache.felix/org.apache.felix.eventadmin/${felix.eventadmin.version}</bundle> > > I think the depedency attribute should be set to "false", else it > won't be installed if you deploy the obr feature before that I think. > > > + <bundle > dependency="true">mvn:org.apache.felix/org.apache.felix.webconsole.plugins.event/${felix.eventadmin-plugin.version}</bundle> > > Same here. However, won't that make the feature fail if the web > console is not installed? > > > + </feature> > > <feature name="jasypt-encryption" version="${project.version}" > resolver="(obr)"> > > <bundle > dependency='true'>mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.commons-codec/${commons-codec.bundle.version}</bundle> > > <bundle > dependency='true'>mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.commons-lang/${commons-lang.bundle.version}</bundle> > > > > > > > > > > -- > Cheers, > Guillaume Nodet > ------------------------ > Blog: http://gnodet.blogspot.com/ > ------------------------ > Open Source SOA > http://fusesource.com > |
Re: svn commit: r1039196 - /karaf/trunk/assembly/src/main
|
|
about the failing of a plugin if the webconsole is not available, I don't
think so but I will validate this later on too. As I told you I'm working on a JMX-Webconsole Plugin, that one can be installed without any issues (I think it even resolves) while the Webconsole is not available. hmm but since I'm providing this through the deploy folder I surely have to check. 2010/11/26 Achim Nierbeck <[hidden email]> > Thanks I will fix this, tonight. > > 2010/11/25 Guillaume Nodet <[hidden email]> > > On Thu, Nov 25, 2010 at 23:06, <[hidden email]> wrote: >> > Author: anierbeck >> > Date: Thu Nov 25 22:06:39 2010 >> > New Revision: 1039196 >> > >> > URL: http://svn.apache.org/viewvc?rev=1039196&view=rev >> > Log: >> > [KARAF-290] Added additional dependency for EventAdminService >> > >> > Modified: >> > karaf/trunk/assembly/src/main/filtered-resources/features.xml >> > >> > Modified: karaf/trunk/assembly/src/main/filtered-resources/features.xml >> > URL: >> http://svn.apache.org/viewvc/karaf/trunk/assembly/src/main/filtered-resources/features.xml?rev=1039196&r1=1039195&r2=1039196&view=diff >> > >> ============================================================================== >> > --- karaf/trunk/assembly/src/main/filtered-resources/features.xml >> (original) >> > +++ karaf/trunk/assembly/src/main/filtered-resources/features.xml Thu >> Nov 25 22:06:39 2010 >> > @@ -125,6 +125,10 @@ >> > >> <bundle>mvn:org.apache.aries.jmx/org.apache.aries.jmx/${aries.jmx.version}</bundle> >> > >> <bundle>mvn:org.apache.aries.jmx/org.apache.aries.jmx.blueprint/${aries.jmx.version}</bundle> >> > </feature> >> > + <feature name="eventadmin" version="${project.version}" >> resolver="(obr)"> >> > + <bundle >> dependency="true">mvn:org.apache.felix/org.apache.felix.eventadmin/${felix.eventadmin.version}</bundle> >> >> I think the depedency attribute should be set to "false", else it >> won't be installed if you deploy the obr feature before that I think. >> >> > + <bundle >> dependency="true">mvn:org.apache.felix/org.apache.felix.webconsole.plugins.event/${felix.eventadmin-plugin.version}</bundle> >> >> Same here. However, won't that make the feature fail if the web >> console is not installed? >> >> > + </feature> >> > <feature name="jasypt-encryption" version="${project.version}" >> resolver="(obr)"> >> > <bundle >> dependency='true'>mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.commons-codec/${commons-codec.bundle.version}</bundle> >> > <bundle >> dependency='true'>mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.commons-lang/${commons-lang.bundle.version}</bundle> >> > >> > >> > >> >> >> >> -- >> Cheers, >> Guillaume Nodet >> ------------------------ >> Blog: http://gnodet.blogspot.com/ >> ------------------------ >> Open Source SOA >> http://fusesource.com >> > > |
Re: svn commit: r1039196 - /karaf/trunk/assembly/src/main
|
|
Ok I was wrong, the webconsole plugin fails, is it OK to deploy the
webconsole plugin without the represented service? I guess so, since the OBR plugin is also installed even so the feature itself might not be. > about the failing of a plugin if the webconsole is not available, I > don't think so but I will validate this later on too. As I told you > I'm working on a JMX-Webconsole Plugin, that one can be installed > without any issues (I think it even resolves) while the Webconsole is > not available. hmm but since I'm providing this through the deploy > folder I surely have to check. > > 2010/11/26 Achim Nierbeck <[hidden email] > <mailto:[hidden email]>> > > Thanks I will fix this, tonight. > > 2010/11/25 Guillaume Nodet <[hidden email] > <mailto:[hidden email]>> > > On Thu, Nov 25, 2010 at 23:06, <[hidden email] > <mailto:[hidden email]>> wrote: > > Author: anierbeck > > Date: Thu Nov 25 22:06:39 2010 > > New Revision: 1039196 > > > > URL: http://svn.apache.org/viewvc?rev=1039196&view=rev > <http://svn.apache.org/viewvc?rev=1039196&view=rev> > > Log: > > [KARAF-290] Added additional dependency for EventAdminService > > > > Modified: > > karaf/trunk/assembly/src/main/filtered-resources/features.xml > > > > Modified: > karaf/trunk/assembly/src/main/filtered-resources/features.xml > > URL: > http://svn.apache.org/viewvc/karaf/trunk/assembly/src/main/filtered-resources/features.xml?rev=1039196&r1=1039195&r2=1039196&view=diff > <http://svn.apache.org/viewvc/karaf/trunk/assembly/src/main/filtered-resources/features.xml?rev=1039196&r1=1039195&r2=1039196&view=diff> > > > ============================================================================== > > --- > karaf/trunk/assembly/src/main/filtered-resources/features.xml > (original) > > +++ > karaf/trunk/assembly/src/main/filtered-resources/features.xml > Thu Nov 25 22:06:39 2010 > > @@ -125,6 +125,10 @@ > > > <bundle>mvn:org.apache.aries.jmx/org.apache.aries.jmx/${aries.jmx.version}</bundle> > > > <bundle>mvn:org.apache.aries.jmx/org.apache.aries.jmx.blueprint/${aries.jmx.version}</bundle> > > </feature> > > + <feature name="eventadmin" version="${project.version}" > resolver="(obr)"> > > + <bundle > dependency="true">mvn:org.apache.felix/org.apache.felix.eventadmin/${felix.eventadmin.version}</bundle> > > I think the depedency attribute should be set to "false", else it > won't be installed if you deploy the obr feature before that I > think. > > > + <bundle > dependency="true">mvn:org.apache.felix/org.apache.felix.webconsole.plugins.event/${felix.eventadmin-plugin.version}</bundle> > > Same here. However, won't that make the feature fail if the web > console is not installed? > > > + </feature> > > <feature name="jasypt-encryption" > version="${project.version}" resolver="(obr)"> > > <bundle > dependency='true'>mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.commons-codec/${commons-codec.bundle.version}</bundle> > > <bundle > dependency='true'>mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.commons-lang/${commons-lang.bundle.version}</bundle> > > > > > > > > > > -- > Cheers, > Guillaume Nodet > ------------------------ > Blog: http://gnodet.blogspot.com/ > ------------------------ > Open Source SOA > http://fusesource.com > > > |
Re: svn commit: r1039196 - /karaf/trunk/assembly/src/main
|
|
Yeah, usually web console plugins bundles can be installed and should
activate the plugin only when the service is available (or gracefully handle the case where the service isn't present for builtins plugins). I guess it would be better to install this plugin from the webconsole feature ... On Fri, Nov 26, 2010 at 22:48, Achim Nierbeck <[hidden email]> wrote: > Ok I was wrong, the webconsole plugin fails, is it OK to deploy the > webconsole plugin without the represented service? > I guess so, since the OBR plugin is also installed even so the feature > itself might not be. >> about the failing of a plugin if the webconsole is not available, I >> don't think so but I will validate this later on too. As I told you >> I'm working on a JMX-Webconsole Plugin, that one can be installed >> without any issues (I think it even resolves) while the Webconsole is >> not available. hmm but since I'm providing this through the deploy >> folder I surely have to check. >> >> 2010/11/26 Achim Nierbeck <[hidden email] >> <mailto:[hidden email]>> >> >> Thanks I will fix this, tonight. >> >> 2010/11/25 Guillaume Nodet <[hidden email] >> <mailto:[hidden email]>> >> >> On Thu, Nov 25, 2010 at 23:06, <[hidden email] >> <mailto:[hidden email]>> wrote: >> > Author: anierbeck >> > Date: Thu Nov 25 22:06:39 2010 >> > New Revision: 1039196 >> > >> > URL: http://svn.apache.org/viewvc?rev=1039196&view=rev >> <http://svn.apache.org/viewvc?rev=1039196&view=rev> >> > Log: >> > [KARAF-290] Added additional dependency for EventAdminService >> > >> > Modified: >> > karaf/trunk/assembly/src/main/filtered-resources/features.xml >> > >> > Modified: >> karaf/trunk/assembly/src/main/filtered-resources/features.xml >> > URL: >> http://svn.apache.org/viewvc/karaf/trunk/assembly/src/main/filtered-resources/features.xml?rev=1039196&r1=1039195&r2=1039196&view=diff >> <http://svn.apache.org/viewvc/karaf/trunk/assembly/src/main/filtered-resources/features.xml?rev=1039196&r1=1039195&r2=1039196&view=diff> >> > >> ============================================================================== >> > --- >> karaf/trunk/assembly/src/main/filtered-resources/features.xml >> (original) >> > +++ >> karaf/trunk/assembly/src/main/filtered-resources/features.xml >> Thu Nov 25 22:06:39 2010 >> > @@ -125,6 +125,10 @@ >> > >> <bundle>mvn:org.apache.aries.jmx/org.apache.aries.jmx/${aries.jmx.version}</bundle> >> > >> <bundle>mvn:org.apache.aries.jmx/org.apache.aries.jmx.blueprint/${aries.jmx.version}</bundle> >> > </feature> >> > + <feature name="eventadmin" version="${project.version}" >> resolver="(obr)"> >> > + <bundle >> dependency="true">mvn:org.apache.felix/org.apache.felix.eventadmin/${felix.eventadmin.version}</bundle> >> >> I think the depedency attribute should be set to "false", else it >> won't be installed if you deploy the obr feature before that I >> think. >> >> > + <bundle >> dependency="true">mvn:org.apache.felix/org.apache.felix.webconsole.plugins.event/${felix.eventadmin-plugin.version}</bundle> >> >> Same here. However, won't that make the feature fail if the web >> console is not installed? >> >> > + </feature> >> > <feature name="jasypt-encryption" >> version="${project.version}" resolver="(obr)"> >> > <bundle >> dependency='true'>mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.commons-codec/${commons-codec.bundle.version}</bundle> >> > <bundle >> dependency='true'>mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.commons-lang/${commons-lang.bundle.version}</bundle> >> > >> > >> > >> >> >> >> -- >> Cheers, >> Guillaume Nodet >> ------------------------ >> Blog: http://gnodet.blogspot.com/ >> ------------------------ >> Open Source SOA >> http://fusesource.com >> >> >> > > -- Cheers, Guillaume Nodet ------------------------ Blog: http://gnodet.blogspot.com/ ------------------------ Open Source SOA http://fusesource.com |
Re: svn commit: r1039196 - /karaf/trunk/assembly/src/main
|
|
I just tried, and guess what the plugin even works without eventadmin, I
guess i looks through the "events" registered by the logservice than. :) > Yeah, usually web console plugins bundles can be installed and should > activate the plugin only when the service is available (or gracefully > handle the case where the service isn't present for builtins plugins). > I guess it would be better to install this plugin from the webconsole > feature ... > > On Fri, Nov 26, 2010 at 22:48, Achim Nierbeck <[hidden email]> wrote: >> Ok I was wrong, the webconsole plugin fails, is it OK to deploy the >> webconsole plugin without the represented service? >> I guess so, since the OBR plugin is also installed even so the feature >> itself might not be. >>> about the failing of a plugin if the webconsole is not available, I >>> don't think so but I will validate this later on too. As I told you >>> I'm working on a JMX-Webconsole Plugin, that one can be installed >>> without any issues (I think it even resolves) while the Webconsole is >>> not available. hmm but since I'm providing this through the deploy >>> folder I surely have to check. >>> >>> 2010/11/26 Achim Nierbeck <[hidden email] >>> <mailto:[hidden email]>> >>> >>> Thanks I will fix this, tonight. >>> >>> 2010/11/25 Guillaume Nodet <[hidden email] >>> <mailto:[hidden email]>> >>> >>> On Thu, Nov 25, 2010 at 23:06, <[hidden email] >>> <mailto:[hidden email]>> wrote: >>> > Author: anierbeck >>> > Date: Thu Nov 25 22:06:39 2010 >>> > New Revision: 1039196 >>> > >>> > URL: http://svn.apache.org/viewvc?rev=1039196&view=rev >>> <http://svn.apache.org/viewvc?rev=1039196&view=rev> >>> > Log: >>> > [KARAF-290] Added additional dependency for EventAdminService >>> > >>> > Modified: >>> > karaf/trunk/assembly/src/main/filtered-resources/features.xml >>> > >>> > Modified: >>> karaf/trunk/assembly/src/main/filtered-resources/features.xml >>> > URL: >>> http://svn.apache.org/viewvc/karaf/trunk/assembly/src/main/filtered-resources/features.xml?rev=1039196&r1=1039195&r2=1039196&view=diff >>> <http://svn.apache.org/viewvc/karaf/trunk/assembly/src/main/filtered-resources/features.xml?rev=1039196&r1=1039195&r2=1039196&view=diff> >>> > >>> ============================================================================== >>> > --- >>> karaf/trunk/assembly/src/main/filtered-resources/features.xml >>> (original) >>> > +++ >>> karaf/trunk/assembly/src/main/filtered-resources/features.xml >>> Thu Nov 25 22:06:39 2010 >>> > @@ -125,6 +125,10 @@ >>> > >>> <bundle>mvn:org.apache.aries.jmx/org.apache.aries.jmx/${aries.jmx.version}</bundle> >>> > >>> <bundle>mvn:org.apache.aries.jmx/org.apache.aries.jmx.blueprint/${aries.jmx.version}</bundle> >>> > </feature> >>> > + <feature name="eventadmin" version="${project.version}" >>> resolver="(obr)"> >>> > + <bundle >>> dependency="true">mvn:org.apache.felix/org.apache.felix.eventadmin/${felix.eventadmin.version}</bundle> >>> >>> I think the depedency attribute should be set to "false", else it >>> won't be installed if you deploy the obr feature before that I >>> think. >>> >>> > + <bundle >>> dependency="true">mvn:org.apache.felix/org.apache.felix.webconsole.plugins.event/${felix.eventadmin-plugin.version}</bundle> >>> >>> Same here. However, won't that make the feature fail if the web >>> console is not installed? >>> >>> > + </feature> >>> > <feature name="jasypt-encryption" >>> version="${project.version}" resolver="(obr)"> >>> > <bundle >>> dependency='true'>mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.commons-codec/${commons-codec.bundle.version}</bundle> >>> > <bundle >>> dependency='true'>mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.commons-lang/${commons-lang.bundle.version}</bundle> >>> > >>> > >>> > >>> >>> >>> >>> -- >>> Cheers, >>> Guillaume Nodet >>> ------------------------ >>> Blog: http://gnodet.blogspot.com/ >>> ------------------------ >>> Open Source SOA >>> http://fusesource.com >>> >>> >>> >> > > |
«
Return to Karaf - Dev
|
1 view|%1 views
Loading...
| Powered by Nabble | Edit this page |