Karaf › Karaf - Dev

Re: svn commit: r1303149 - /karaf/trunk/itests/tests/src/test/resources/org/apache/karaf/testing/startup.properties

Classic

List

Threaded

5 messages Options

Achim Nierbeck

Re: svn commit: r1303149 - /karaf/trunk/itests/tests/src/test/resources/org/apache/karaf/testing/startup.properties

AFAIK switching to the latest snapshots requires also the bndlib jar,
but since the latest version 1.50.0 does an import for junit.framework I
suggest using the previous version 1.43.0
At least that's the version I successfully tested pax-web with :)

regards, Achim

Am 20.03.2012 22:01, schrieb [hidden email]:

> Author: cschneider
> Date: Tue Mar 20 21:01:39 2012
> New Revision: 1303149
>
> URL: http://svn.apache.org/viewvc?rev=1303149&view=rev
> Log:
> Try to fix itests
>
> Modified:
> karaf/trunk/itests/tests/src/test/resources/org/apache/karaf/testing/startup.properties
>
> Modified: karaf/trunk/itests/tests/src/test/resources/org/apache/karaf/testing/startup.properties
> URL: http://svn.apache.org/viewvc/karaf/trunk/itests/tests/src/test/resources/org/apache/karaf/testing/startup.properties?rev=1303149&r1=1303148&r2=1303149&view=diff
> ==============================================================================
> --- karaf/trunk/itests/tests/src/test/resources/org/apache/karaf/testing/startup.properties (original)
> +++ karaf/trunk/itests/tests/src/test/resources/org/apache/karaf/testing/startup.properties Tue Mar 20 21:01:39 2012
> @@ -1,10 +1,14 @@
> # Testing startup.properties
> +#Bundles to be started on startup, with startlevel
> +
> +# feature: framework version: 3.0.0-SNAPSHOT
> mvn\:org.ops4j.base/ops4j-base-lang/1.3.0 = 5
> mvn\:org.apache.servicemix.bundles/org.apache.servicemix.bundles.junit/3.8.2_4 = 5
> mvn\:biz.aQute/bndlib/1.50.0 = 5
> mvn\:org.ops4j.pax.swissbox/pax-swissbox-bnd/1.5.0 = 5
> -mvn\:org.ops4j.pax.url/pax-url-aether/1.4.0.RC1 = 5
> -mvn\:org.ops4j.pax.url/pax-url-wrap/1.4.0.RC1 = 5
> +mvn\:org.ops4j.pax.url/pax-url-maven-commons/1.4-SNAPSHOT = 5
> +mvn\:org.ops4j.pax.url/pax-url-aether/1.4-SNAPSHOT = 5
> +mvn\:org.ops4j.pax.url/pax-url-wrap/1.4-SNAPSHOT = 5
> mvn\:org.ops4j.pax.logging/pax-logging-api/1.6.5 = 8
> mvn\:org.ops4j.pax.logging/pax-logging-service/1.6.5 = 8
> mvn\:org.apache.felix/org.apache.felix.configadmin/1.2.8 = 10
> @@ -17,20 +21,25 @@ mvn\:org.apache.aries.blueprint/org.apac
> mvn\:org.apache.aries.blueprint/org.apache.aries.blueprint.cm/0.3.3-SNAPSHOT = 20
> mvn\:org.apache.aries.blueprint/org.apache.aries.blueprint.core.compatibility/0.4.1-SNAPSHOT = 20
> mvn\:org.apache.aries.blueprint/org.apache.aries.blueprint.core/0.4.1-SNAPSHOT = 20
> +mvn\:org.apache.karaf.deployer/org.apache.karaf.deployer.spring/3.0.0-SNAPSHOT = 24
> +mvn\:org.apache.karaf.deployer/org.apache.karaf.deployer.blueprint/3.0.0-SNAPSHOT = 24
> mvn\:org.apache.karaf.region/org.apache.karaf.region.core/3.0.0-SNAPSHOT = 25
> mvn\:org.apache.karaf.features/org.apache.karaf.features.core/3.0.0-SNAPSHOT = 25
> -mvn\:org.ops4j.pax.url/pax-url-commons/1.4.0.RC1 = 30
> -mvn\:org.ops4j.pax.swissbox/pax-swissbox-property/1.5.0 = 30
> mvn\:org.ops4j.base/ops4j-base-util-property/1.3.0 = 30
> +mvn\:org.ops4j.base/ops4j-base-util-xml/1.3.0 = 30
> +mvn\:org.ops4j.base/ops4j-base-util-collections/1.3.0 = 30
> +mvn\:org.ops4j.pax.url/pax-url-commons/1.4-SNAPSHOT = 30
> +mvn\:org.ops4j.pax.swissbox/pax-swissbox-property/1.5.0 = 30
> mvn\:org.ops4j.base/ops4j-base-net/1.3.0 = 30
> mvn\:org.ops4j.base/ops4j-base-monitors/1.3.0 = 30
> mvn\:org.apache.karaf.features/org.apache.karaf.features.command/3.0.0-SNAPSHOT = 30
> mvn\:org.apache.karaf.shell/org.apache.karaf.shell.console/3.0.0-SNAPSHOT = 30
> mvn\:org.apache.karaf.jaas/org.apache.karaf.jaas.modules/3.0.0-SNAPSHOT = 30
> mvn\:org.apache.karaf.jaas/org.apache.karaf.jaas.config/3.0.0-SNAPSHOT = 30
> -mvn\:org.apache.karaf.shell/org.apache.karaf.shell.bundles/3.0.0-SNAPSHOT = 30
> +mvn\:org.apache.karaf.bundle/org.apache.karaf.bundle.command/3.0.0-SNAPSHOT = 30
> +mvn\:org.apache.karaf.bundle/org.apache.karaf.bundle.core/3.0.0-SNAPSHOT = 30
> mvn\:org.apache.karaf.shell/org.apache.karaf.shell.services/3.0.0-SNAPSHOT = 30
> mvn\:org.apache.karaf.system/org.apache.karaf.system.core/3.0.0-SNAPSHOT = 30
> mvn\:org.apache.karaf.system/org.apache.karaf.system.commands/3.0.0-SNAPSHOT = 30
> mvn\:org.apache.karaf.shell/org.apache.karaf.shell.commands/3.0.0-SNAPSHOT = 30
> -mvn\:org.apache.aries.quiesce/org.apache.aries.quiesce.api/0.3 = 30
> \ No newline at end of file
> +mvn\:org.apache.aries.quiesce/org.apache.aries.quiesce.api/0.3 = 30
>
>

--
- Apache Karaf<http://karaf.apache.org/> Committer& PMC
- OPS4J Pax Web<http://wiki.ops4j.org/display/paxweb/Pax+Web/> Committer& Project Lead
- Blog<http://notizblog.nierbeck.de/>

jbonofre

Re: svn commit: r1303149 - /karaf/trunk/itests/tests/src/test/resources/org/apache/karaf/testing/startup.properties

Anyway, as the startup.properties is generated, we don't have the
guarantee that the one that we test is the one that we distribute.

I propose:
1/ don't generate the startup.properties, define it by hand, and use the
same for itests, tests and distro
2/ update the plugin and/or reactor to generate the startup.properties
in an early stage and use it in itests, tests and distro

I'm more in favor of 2, I will try to work on it tonight from the airport.

Regards
JB

On 03/20/2012 10:31 PM, Achim Nierbeck wrote:

> AFAIK switching to the latest snapshots requires also the bndlib jar,
> but since the latest version 1.50.0 does an import for junit.framework I
> suggest using the previous version 1.43.0
> At least that's the version I successfully tested pax-web with :)
>
> regards, Achim
>
> Am 20.03.2012 22:01, schrieb [hidden email]:
>> Author: cschneider
>> Date: Tue Mar 20 21:01:39 2012
>> New Revision: 1303149
>>
>> URL: http://svn.apache.org/viewvc?rev=1303149&view=rev
>> Log:
>> Try to fix itests
>>
>> Modified:
>> karaf/trunk/itests/tests/src/test/resources/org/apache/karaf/testing/startup.properties
>>
>>
>> Modified:
>> karaf/trunk/itests/tests/src/test/resources/org/apache/karaf/testing/startup.properties
>>
>> URL:
>> http://svn.apache.org/viewvc/karaf/trunk/itests/tests/src/test/resources/org/apache/karaf/testing/startup.properties?rev=1303149&r1=1303148&r2=1303149&view=diff
>>
>> ==============================================================================
>>
>> ---
>> karaf/trunk/itests/tests/src/test/resources/org/apache/karaf/testing/startup.properties
>> (original)
>> +++
>> karaf/trunk/itests/tests/src/test/resources/org/apache/karaf/testing/startup.properties
>> Tue Mar 20 21:01:39 2012
>> @@ -1,10 +1,14 @@
>> # Testing startup.properties
>> +#Bundles to be started on startup, with startlevel
>> +
>> +# feature: framework version: 3.0.0-SNAPSHOT
>> mvn\:org.ops4j.base/ops4j-base-lang/1.3.0 = 5
>> mvn\:org.apache.servicemix.bundles/org.apache.servicemix.bundles.junit/3.8.2_4
>> = 5
>> mvn\:biz.aQute/bndlib/1.50.0 = 5
>> mvn\:org.ops4j.pax.swissbox/pax-swissbox-bnd/1.5.0 = 5
>> -mvn\:org.ops4j.pax.url/pax-url-aether/1.4.0.RC1 = 5
>> -mvn\:org.ops4j.pax.url/pax-url-wrap/1.4.0.RC1 = 5
>> +mvn\:org.ops4j.pax.url/pax-url-maven-commons/1.4-SNAPSHOT = 5
>> +mvn\:org.ops4j.pax.url/pax-url-aether/1.4-SNAPSHOT = 5
>> +mvn\:org.ops4j.pax.url/pax-url-wrap/1.4-SNAPSHOT = 5
>> mvn\:org.ops4j.pax.logging/pax-logging-api/1.6.5 = 8
>> mvn\:org.ops4j.pax.logging/pax-logging-service/1.6.5 = 8
>> mvn\:org.apache.felix/org.apache.felix.configadmin/1.2.8 = 10
>> @@ -17,20 +21,25 @@ mvn\:org.apache.aries.blueprint/org.apac
>> mvn\:org.apache.aries.blueprint/org.apache.aries.blueprint.cm/0.3.3-SNAPSHOT
>> = 20
>> mvn\:org.apache.aries.blueprint/org.apache.aries.blueprint.core.compatibility/0.4.1-SNAPSHOT
>> = 20
>> mvn\:org.apache.aries.blueprint/org.apache.aries.blueprint.core/0.4.1-SNAPSHOT
>> = 20
>> +mvn\:org.apache.karaf.deployer/org.apache.karaf.deployer.spring/3.0.0-SNAPSHOT
>> = 24
>> +mvn\:org.apache.karaf.deployer/org.apache.karaf.deployer.blueprint/3.0.0-SNAPSHOT
>> = 24
>> mvn\:org.apache.karaf.region/org.apache.karaf.region.core/3.0.0-SNAPSHOT
>> = 25
>> mvn\:org.apache.karaf.features/org.apache.karaf.features.core/3.0.0-SNAPSHOT
>> = 25
>> -mvn\:org.ops4j.pax.url/pax-url-commons/1.4.0.RC1 = 30
>> -mvn\:org.ops4j.pax.swissbox/pax-swissbox-property/1.5.0 = 30
>> mvn\:org.ops4j.base/ops4j-base-util-property/1.3.0 = 30
>> +mvn\:org.ops4j.base/ops4j-base-util-xml/1.3.0 = 30
>> +mvn\:org.ops4j.base/ops4j-base-util-collections/1.3.0 = 30
>> +mvn\:org.ops4j.pax.url/pax-url-commons/1.4-SNAPSHOT = 30
>> +mvn\:org.ops4j.pax.swissbox/pax-swissbox-property/1.5.0 = 30
>> mvn\:org.ops4j.base/ops4j-base-net/1.3.0 = 30
>> mvn\:org.ops4j.base/ops4j-base-monitors/1.3.0 = 30
>> mvn\:org.apache.karaf.features/org.apache.karaf.features.command/3.0.0-SNAPSHOT
>> = 30
>> mvn\:org.apache.karaf.shell/org.apache.karaf.shell.console/3.0.0-SNAPSHOT
>> = 30
>> mvn\:org.apache.karaf.jaas/org.apache.karaf.jaas.modules/3.0.0-SNAPSHOT =
>> 30
>> mvn\:org.apache.karaf.jaas/org.apache.karaf.jaas.config/3.0.0-SNAPSHOT
>> = 30
>> -mvn\:org.apache.karaf.shell/org.apache.karaf.shell.bundles/3.0.0-SNAPSHOT
>> = 30
>> +mvn\:org.apache.karaf.bundle/org.apache.karaf.bundle.command/3.0.0-SNAPSHOT
>> = 30
>> +mvn\:org.apache.karaf.bundle/org.apache.karaf.bundle.core/3.0.0-SNAPSHOT
>> = 30
>> mvn\:org.apache.karaf.shell/org.apache.karaf.shell.services/3.0.0-SNAPSHOT
>> = 30
>> mvn\:org.apache.karaf.system/org.apache.karaf.system.core/3.0.0-SNAPSHOT
>> = 30
>> mvn\:org.apache.karaf.system/org.apache.karaf.system.commands/3.0.0-SNAPSHOT
>> = 30
>> mvn\:org.apache.karaf.shell/org.apache.karaf.shell.commands/3.0.0-SNAPSHOT
>> = 30
>> -mvn\:org.apache.aries.quiesce/org.apache.aries.quiesce.api/0.3 = 30
>> \ No newline at end of file
>> +mvn\:org.apache.aries.quiesce/org.apache.aries.quiesce.api/0.3 = 30
>>
>>
>
>

--
Jean-Baptiste Onofré
[hidden email]
http://blog.nanthrax.net
Talend - http://www.talend.com

David Jencks

Re: svn commit: r1303149 - /karaf/trunk/itests/tests/src/test/resources/org/apache/karaf/testing/startup.properties

It's been a while but I don't understand why a startup.properties is in svn for itests. Don't the itests use one of the karaf assemblies? if not, why not?

I thought the build order was

...
assemblies
itests (that use the assemblies).

So I don't undersand either of your proposals.

thanks
david jencks

On Mar 20, 2012, at 10:24 PM, Jean-Baptiste Onofré wrote:

> Anyway, as the startup.properties is generated, we don't have the guarantee that the one that we test is the one that we distribute.

>
> I propose:
> 1/ don't generate the startup.properties, define it by hand, and use the same for itests, tests and distro
> 2/ update the plugin and/or reactor to generate the startup.properties in an early stage and use it in itests, tests and distro
>
> I'm more in favor of 2, I will try to work on it tonight from the airport.
>
> Regards
> JB
>
> On 03/20/2012 10:31 PM, Achim Nierbeck wrote:
>> AFAIK switching to the latest snapshots requires also the bndlib jar,
>> but since the latest version 1.50.0 does an import for junit.framework I
>> suggest using the previous version 1.43.0
>> At least that's the version I successfully tested pax-web with :)
>>
>> regards, Achim
>>
>> Am 20.03.2012 22:01, schrieb [hidden email]:
>>> Author: cschneider
>>> Date: Tue Mar 20 21:01:39 2012
>>> New Revision: 1303149
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1303149&view=rev
>>> Log:
>>> Try to fix itests
>>>
>>> Modified:
>>> karaf/trunk/itests/tests/src/test/resources/org/apache/karaf/testing/startup.properties
>>>
>>>
>>> Modified:
>>> karaf/trunk/itests/tests/src/test/resources/org/apache/karaf/testing/startup.properties
>>>
>>> URL:
>>> http://svn.apache.org/viewvc/karaf/trunk/itests/tests/src/test/resources/org/apache/karaf/testing/startup.properties?rev=1303149&r1=1303148&r2=1303149&view=diff
>>>
>>> ==============================================================================
>>>
>>> ---
>>> karaf/trunk/itests/tests/src/test/resources/org/apache/karaf/testing/startup.properties
>>> (original)
>>> +++
>>> karaf/trunk/itests/tests/src/test/resources/org/apache/karaf/testing/startup.properties
>>> Tue Mar 20 21:01:39 2012
>>> @@ -1,10 +1,14 @@
>>> # Testing startup.properties
>>> +#Bundles to be started on startup, with startlevel
>>> +
>>> +# feature: framework version: 3.0.0-SNAPSHOT
>>> mvn\:org.ops4j.base/ops4j-base-lang/1.3.0 = 5
>>> mvn\:org.apache.servicemix.bundles/org.apache.servicemix.bundles.junit/3.8.2_4
>>> = 5
>>> mvn\:biz.aQute/bndlib/1.50.0 = 5
>>> mvn\:org.ops4j.pax.swissbox/pax-swissbox-bnd/1.5.0 = 5
>>> -mvn\:org.ops4j.pax.url/pax-url-aether/1.4.0.RC1 = 5
>>> -mvn\:org.ops4j.pax.url/pax-url-wrap/1.4.0.RC1 = 5
>>> +mvn\:org.ops4j.pax.url/pax-url-maven-commons/1.4-SNAPSHOT = 5
>>> +mvn\:org.ops4j.pax.url/pax-url-aether/1.4-SNAPSHOT = 5
>>> +mvn\:org.ops4j.pax.url/pax-url-wrap/1.4-SNAPSHOT = 5
>>> mvn\:org.ops4j.pax.logging/pax-logging-api/1.6.5 = 8
>>> mvn\:org.ops4j.pax.logging/pax-logging-service/1.6.5 = 8
>>> mvn\:org.apache.felix/org.apache.felix.configadmin/1.2.8 = 10
>>> @@ -17,20 +21,25 @@ mvn\:org.apache.aries.blueprint/org.apac
>>> mvn\:org.apache.aries.blueprint/org.apache.aries.blueprint.cm/0.3.3-SNAPSHOT
>>> = 20
>>> mvn\:org.apache.aries.blueprint/org.apache.aries.blueprint.core.compatibility/0.4.1-SNAPSHOT
>>> = 20
>>> mvn\:org.apache.aries.blueprint/org.apache.aries.blueprint.core/0.4.1-SNAPSHOT
>>> = 20
>>> +mvn\:org.apache.karaf.deployer/org.apache.karaf.deployer.spring/3.0.0-SNAPSHOT
>>> = 24
>>> +mvn\:org.apache.karaf.deployer/org.apache.karaf.deployer.blueprint/3.0.0-SNAPSHOT
>>> = 24
>>> mvn\:org.apache.karaf.region/org.apache.karaf.region.core/3.0.0-SNAPSHOT
>>> = 25
>>> mvn\:org.apache.karaf.features/org.apache.karaf.features.core/3.0.0-SNAPSHOT
>>> = 25
>>> -mvn\:org.ops4j.pax.url/pax-url-commons/1.4.0.RC1 = 30
>>> -mvn\:org.ops4j.pax.swissbox/pax-swissbox-property/1.5.0 = 30
>>> mvn\:org.ops4j.base/ops4j-base-util-property/1.3.0 = 30
>>> +mvn\:org.ops4j.base/ops4j-base-util-xml/1.3.0 = 30
>>> +mvn\:org.ops4j.base/ops4j-base-util-collections/1.3.0 = 30
>>> +mvn\:org.ops4j.pax.url/pax-url-commons/1.4-SNAPSHOT = 30
>>> +mvn\:org.ops4j.pax.swissbox/pax-swissbox-property/1.5.0 = 30
>>> mvn\:org.ops4j.base/ops4j-base-net/1.3.0 = 30
>>> mvn\:org.ops4j.base/ops4j-base-monitors/1.3.0 = 30
>>> mvn\:org.apache.karaf.features/org.apache.karaf.features.command/3.0.0-SNAPSHOT
>>> = 30
>>> mvn\:org.apache.karaf.shell/org.apache.karaf.shell.console/3.0.0-SNAPSHOT
>>> = 30
>>> mvn\:org.apache.karaf.jaas/org.apache.karaf.jaas.modules/3.0.0-SNAPSHOT =
>>> 30
>>> mvn\:org.apache.karaf.jaas/org.apache.karaf.jaas.config/3.0.0-SNAPSHOT
>>> = 30
>>> -mvn\:org.apache.karaf.shell/org.apache.karaf.shell.bundles/3.0.0-SNAPSHOT
>>> = 30
>>> +mvn\:org.apache.karaf.bundle/org.apache.karaf.bundle.command/3.0.0-SNAPSHOT
>>> = 30
>>> +mvn\:org.apache.karaf.bundle/org.apache.karaf.bundle.core/3.0.0-SNAPSHOT
>>> = 30
>>> mvn\:org.apache.karaf.shell/org.apache.karaf.shell.services/3.0.0-SNAPSHOT
>>> = 30
>>> mvn\:org.apache.karaf.system/org.apache.karaf.system.core/3.0.0-SNAPSHOT
>>> = 30
>>> mvn\:org.apache.karaf.system/org.apache.karaf.system.commands/3.0.0-SNAPSHOT
>>> = 30
>>> mvn\:org.apache.karaf.shell/org.apache.karaf.shell.commands/3.0.0-SNAPSHOT
>>> = 30
>>> -mvn\:org.apache.aries.quiesce/org.apache.aries.quiesce.api/0.3 = 30
>>> \ No newline at end of file
>>> +mvn\:org.apache.aries.quiesce/org.apache.aries.quiesce.api/0.3 = 30
>>>
>>>
>>
>>
>
> --
> Jean-Baptiste Onofré
> [hidden email]
> http://blog.nanthrax.net
> Talend - http://www.talend.com

jbonofre

Re: svn commit: r1303149 - /karaf/trunk/itests/tests/src/test/resources/org/apache/karaf/testing/startup.properties

In reply to this post by Achim Nierbeck

It's exactly the purpose of my proposal: don't include startup.properties in itests but use the one from assemblies.

--
Jean-Baptiste Onofré
[hidden email]
http://blog.nanthrax.net
Talend - http://wwx.talend.com

----- Reply message -----
From: "David Jencks" <[hidden email]>
To: <[hidden email]>
Subject: svn commit: r1303149 - /karaf/trunk/itests/tests/src/test/resources/org/apache/karaf/testing/startup.properties
Date: Wed, Mar 21, 2012 7:34 am

It's been a while but I don't understand why a startup.properties is in svn for itests. Don't the itests use one of the karaf assemblies? if not, why not?

I thought the build order was

...
assemblies
itests (that use the assemblies).

So I don't undersand either of your proposals.

thanks
david jencks

On Mar 20, 2012, at 10:24 PM, Jean-Baptiste Onofré wrote:

> Anyway, as the startup.properties is generated, we don't have the guarantee that the one that we test is the one that we distribute.

jbonofre

Re: svn commit: r1303149 - /karaf/trunk/itests/tests/src/test/resources/org/apache/karaf/testing/startup.properties

In reply to this post by Achim Nierbeck

For reminder, afair, we override startup.properties in instance (previously admin) tests as it's earlier in the reactor than assemblies. But it's another topic ;)

--
Jean-Baptiste Onofré
[hidden email]
http://blog.nanthrax.net
Talend - http://wwx.talend.com

----- Reply message -----
From: "David Jencks" <[hidden email]>
To: <[hidden email]>
Subject: svn commit: r1303149 - /karaf/trunk/itests/tests/src/test/resources/org/apache/karaf/testing/startup.properties
Date: Wed, Mar 21, 2012 7:34 am

It's been a while but I don't understand why a startup.properties is in svn for itests. Don't the itests use one of the karaf assemblies? if not, why not?

I thought the build order was

...
assemblies
itests (that use the assemblies).

So I don't undersand either of your proposals.

thanks
david jencks

On Mar 20, 2012, at 10:24 PM, Jean-Baptiste Onofré wrote:

> Anyway, as the startup.properties is generated, we don't have the guarantee that the one that we test is the one that we distribute.