Karaf › Karaf - Dev

Trunk build broken

Classic

List

Threaded

10 messages Options

jbonofre

Trunk build broken

Hi guys,

FYI, Christian has broken the trunk yesterday evening with his latest
commit:

The bundle/core BlueprintListener import
org.apache.karaf.bundle.core.BundleState which doesn't exist.

I'm fixing that and will respin a Jenkins build.

Regards
JB
--
Jean-Baptiste Onofré
[hidden email]
http://blog.nanthrax.net
Talend - http://www.talend.com

jbonofre

Re: Trunk build broken

I fixed the issue on bundle/core, but now, I have an issue on bundle
command which don't find ShellUtil (because it has been moved).

I guess that the Christian commit is not complete, or it means that he
didn't try to compile ;)

Regards
JB

On 03/20/2012 09:11 AM, Jean-Baptiste Onofré wrote:

> Hi guys,
>
> FYI, Christian has broken the trunk yesterday evening with his latest
> commit:
>
> The bundle/core BlueprintListener import
> org.apache.karaf.bundle.core.BundleState which doesn't exist.
>
> I'm fixing that and will respin a Jenkins build.
>
> Regards
> JB

--
Jean-Baptiste Onofré
[hidden email]
http://blog.nanthrax.net
Talend - http://www.talend.com

cschneider

Re: Trunk build broken

Damn .. .seems I missed the added classes.

Will fix it.

Christian

Am 20.03.2012 09:21, schrieb Jean-Baptiste Onofré:

> I fixed the issue on bundle/core, but now, I have an issue on bundle
> command which don't find ShellUtil (because it has been moved).
>
> I guess that the Christian commit is not complete, or it means that he
> didn't try to compile ;)
>
> Regards
> JB
>
> On 03/20/2012 09:11 AM, Jean-Baptiste Onofré wrote:
>> Hi guys,
>>
>> FYI, Christian has broken the trunk yesterday evening with his latest
>> commit:
>>
>> The bundle/core BlueprintListener import
>> org.apache.karaf.bundle.core.BundleState which doesn't exist.
>>
>> I'm fixing that and will respin a Jenkins build.
>>
>> Regards
>> JB
>

--

Christian Schneider
http://www.liquid-reality.de

Open Source Architect
Talend Application Integration Division http://www.talend.com

jbonofre

Re: Trunk build broken

In reply to this post by jbonofre

If the build has been fixed, the current assembly doesn't work fine:

- the bundle scope commands are not available.

It's due to a bad order in the startup or dependencies:

2012-03-23 19:10:53,549 | INFO | rint Extender: 2 |
BlueprintContainerImpl | container.BlueprintContainerImpl 282
| 17 - org.apache.aries.blueprint.core - 0.4.1.SNAPSHOT | Bundle
org.apache.karaf.shell.commands is waiting for namespace handlers
[http://karaf.apache.org/xmlns/shell/v1.1.0]
2012-03-23 19:10:53,549 | INFO | rint Extender: 1 |
BlueprintContainerImpl | container.BlueprintContainerImpl 282
| 17 - org.apache.aries.blueprint.core - 0.4.1.SNAPSHOT | Bundle
org.apache.karaf.bundle.command is waiting for namespace handlers
[http://karaf.apache.org/xmlns/shell/v1.1.0]
2012-03-23 19:10:53,552 | INFO | rint Extender: 2 |
BlueprintContainerImpl | container.BlueprintContainerImpl 282
| 17 - org.apache.aries.blueprint.core - 0.4.1.SNAPSHOT | Bundle
org.apache.karaf.features.command is waiting for namespace handlers
[http://karaf.apache.org/xmlns/shell/v1.1.0]

As Christian made a refactoring, I guess that I missed some
configuration (startup.properties generation, feature definition, others ?).

I gonna take a look and fix that asap to provide a new clean SNAPSHOT.

Regards
JB

On 03/20/2012 09:11 AM, Jean-Baptiste Onofré wrote:

--
Jean-Baptiste Onofré
[hidden email]
http://blog.nanthrax.net
Talend - http://www.talend.com

cschneider

Re: Trunk build broken

On my machine a fresh install of karaf seemed to work. I will also try
to reproduce.

Christian

Am 23.03.2012 19:13, schrieb Jean-Baptiste Onofré:

> If the build has been fixed, the current assembly doesn't work fine:
>
> - the bundle scope commands are not available.
>
> It's due to a bad order in the startup or dependencies:
>
> 2012-03-23 19:10:53,549 | INFO | rint Extender: 2 |
> BlueprintContainerImpl | container.BlueprintContainerImpl
> 282 | 17 - org.apache.aries.blueprint.core - 0.4.1.SNAPSHOT | Bundle
> org.apache.karaf.shell.commands is waiting for namespace handlers
> [http://karaf.apache.org/xmlns/shell/v1.1.0]
> 2012-03-23 19:10:53,549 | INFO | rint Extender: 1 |
> BlueprintContainerImpl | container.BlueprintContainerImpl
> 282 | 17 - org.apache.aries.blueprint.core - 0.4.1.SNAPSHOT | Bundle
> org.apache.karaf.bundle.command is waiting for namespace handlers
> [http://karaf.apache.org/xmlns/shell/v1.1.0]
> 2012-03-23 19:10:53,552 | INFO | rint Extender: 2 |
> BlueprintContainerImpl | container.BlueprintContainerImpl
> 282 | 17 - org.apache.aries.blueprint.core - 0.4.1.SNAPSHOT | Bundle
> org.apache.karaf.features.command is waiting for namespace handlers
> [http://karaf.apache.org/xmlns/shell/v1.1.0]
>
> As Christian made a refactoring, I guess that I missed some
> configuration (startup.properties generation, feature definition,
> others ?).
>
> I gonna take a look and fix that asap to provide a new clean SNAPSHOT.
>
> Regards
> JB
>
> On 03/20/2012 09:11 AM, Jean-Baptiste Onofré wrote:
>> Hi guys,
>>
>> FYI, Christian has broken the trunk yesterday evening with his latest
>> commit:
>>
>> The bundle/core BlueprintListener import
>> org.apache.karaf.bundle.core.BundleState which doesn't exist.
>>
>> I'm fixing that and will respin a Jenkins build.
>>
>> Regards
>> JB
>

--

Christian Schneider
http://www.liquid-reality.de

Open Source Architect
Talend Application Integration Division http://www.talend.com

jbonofre

Re: Trunk build broken

I saw that you committed the fix this morning.

Thanks.

I hope it's not "tortoise" that forgot to commit some files again ;)

Regards
JB

On 03/23/2012 10:04 PM, Christian Schneider wrote:

> On my machine a fresh install of karaf seemed to work. I will also try
> to reproduce.
>
> Christian
>
> Am 23.03.2012 19:13, schrieb Jean-Baptiste Onofré:
>> If the build has been fixed, the current assembly doesn't work fine:
>>
>> - the bundle scope commands are not available.
>>
>> It's due to a bad order in the startup or dependencies:
>>
>> 2012-03-23 19:10:53,549 | INFO | rint Extender: 2 |
>> BlueprintContainerImpl | container.BlueprintContainerImpl 282 | 17 -
>> org.apache.aries.blueprint.core - 0.4.1.SNAPSHOT | Bundle
>> org.apache.karaf.shell.commands is waiting for namespace handlers
>> [http://karaf.apache.org/xmlns/shell/v1.1.0]
>> 2012-03-23 19:10:53,549 | INFO | rint Extender: 1 |
>> BlueprintContainerImpl | container.BlueprintContainerImpl 282 | 17 -
>> org.apache.aries.blueprint.core - 0.4.1.SNAPSHOT | Bundle
>> org.apache.karaf.bundle.command is waiting for namespace handlers
>> [http://karaf.apache.org/xmlns/shell/v1.1.0]
>> 2012-03-23 19:10:53,552 | INFO | rint Extender: 2 |
>> BlueprintContainerImpl | container.BlueprintContainerImpl 282 | 17 -
>> org.apache.aries.blueprint.core - 0.4.1.SNAPSHOT | Bundle
>> org.apache.karaf.features.command is waiting for namespace handlers
>> [http://karaf.apache.org/xmlns/shell/v1.1.0]
>>
>> As Christian made a refactoring, I guess that I missed some
>> configuration (startup.properties generation, feature definition,
>> others ?).
>>
>> I gonna take a look and fix that asap to provide a new clean SNAPSHOT.
>>
>> Regards
>> JB
>>
>> On 03/20/2012 09:11 AM, Jean-Baptiste Onofré wrote:
>>> Hi guys,
>>>
>>> FYI, Christian has broken the trunk yesterday evening with his latest
>>> commit:
>>>
>>> The bundle/core BlueprintListener import
>>> org.apache.karaf.bundle.core.BundleState which doesn't exist.
>>>
>>> I'm fixing that and will respin a Jenkins build.
>>>
>>> Regards
>>> JB
>>
>
>

--
Jean-Baptiste Onofré
[hidden email]
http://blog.nanthrax.net
Talend - http://www.talend.com

cschneider

Re: Trunk build broken

Seems it was the optionality of the reference-list.

Btw. I am not sure if I did this correctly. Will reference list update
the injection if the list of services changes while the bundle runs?

Christian

Am 24.03.2012 09:10, schrieb Jean-Baptiste Onofré:

> I saw that you committed the fix this morning.
>
> Thanks.
>
> I hope it's not "tortoise" that forgot to commit some files again ;)
>
> Regards
> JB
>
>

--

Christian Schneider
http://www.liquid-reality.de

Open Source Architect
Talend Application Integration Division http://www.talend.com

jbonofre

Re: Trunk build broken

OK, I'm going to take a look to validate your fix.

Regards
JB

On 03/24/2012 09:25 AM, Christian Schneider wrote:

> Seems it was the optionality of the reference-list.
>
> Btw. I am not sure if I did this correctly. Will reference list update
> the injection if the list of services changes while the bundle runs?
>
> Christian
>
> Am 24.03.2012 09:10, schrieb Jean-Baptiste Onofré:
>> I saw that you committed the fix this morning.
>>
>> Thanks.
>>
>> I hope it's not "tortoise" that forgot to commit some files again ;)
>>
>> Regards
>> JB
>>
>>
>
>

--
Jean-Baptiste Onofré
[hidden email]
http://blog.nanthrax.net
Talend - http://www.talend.com

iocanel

Re: Trunk build broken

In reply to this post by cschneider

>
> Btw. I am not sure if I did this correctly. Will reference list update the
> injection if the list of services changes while the bundle runs?
>

Yes it will. It will actually add the new services to the list. The setter
will not be called again. If you want to take certain actions upon service
registration/deregistration you'll need to use reference listeners.

--
*Ioannis Canellos*
*
FuseSource <http://fusesource.com>

**
Blog: http://iocanel.blogspot.com
**
Twitter: iocanel
*

Ioannis Canellos
http://iocanel.blogspot.com

cschneider

Re: Trunk build broken

Thanks for the clarification. I do not need special actions. If the list
is up to date that is absolutely great.

Christian

Am 25.03.2012 19:15, schrieb Ioannis Canellos:
>> Btw. I am not sure if I did this correctly. Will reference list update the
>> injection if the list of services changes while the bundle runs?
>>
> Yes it will. It will actually add the new services to the list. The setter
> will not be called again. If you want to take certain actions upon service
> registration/deregistration you'll need to use reference listeners.
>

--

Christian Schneider
http://www.liquid-reality.de

Open Source Architect
Talend Application Integration Division http://www.talend.com